Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development gitpod rsync, gitpod timing, gitpod conditional scaffolding, and QnA project fixes #3

Merged
merged 34 commits into from
Mar 3, 2021

Conversation

apolopena
Copy link
Owner

@apolopena apolopena commented Mar 3, 2021

This PR addresses the following issues and adds some enhancements:

Gitpod related (These changes will be worked into the gitpod-laravel8-starter project)

  1. Missing files and overwritten files when a new workspace is created and scaffolding has already been put in version control.
    • Use rsync instead of mv for copying over laravel project scaffolding created via .gitpod.Dockerfile.
    • Delete the entire ~/test-app folder after rsync of laravel project scaffolding created via .gitpod.Dockerfile.
    • Only install laravel/ui and create front end scaffolding such as react or vue if those files have not yet been put in version control.
  2. Fix timing and console message when opening preview browser to when the main init command is complete.
    • Use gp sync-await and gp sync-done.
    • Implement spinner to notify the user that the preview browser will open when the system is ready.
  3. Add project specific bash code for the init command.
    • Add init-project.sh in the right spot during the main init command.
  4. Remove merge .gitignore from laravel project scaffolding created via .gitpod.Dockerfile to the projects .gitignore
  5. Workaround an apparent gitpod issue that kept apache from starting up: /var/log/apache2/ not found by default
    • From `.gitpod.Dockerfile
      • Create the directory /var/log/apache2
      • Create the file /var/log/apache2/access.log
      • Create the file /var/log/apache2/error.log
      • Create the file /var/log/apache2/other_vhosts_access.log

QnA project related

  1. Add Database seeders
  2. Fixed relationship between Answer and Question models
  3. Log status of project specific setup (see `bash/init-project.sh'): database migration and seeding.
  4. Fix responsivness for certain screen sizes

apolopena and others added 30 commits February 25, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant